Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test against a real grpc server for common/deliverclient/blo… #4826

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

solo-daemon
Copy link
Contributor

@solo-daemon solo-daemon commented Apr 24, 2024

  • Test update

Description

fix #4567

Update unit test for deliveryRequester.

@solo-daemon solo-daemon requested a review from a team as a code owner April 24, 2024 19:55
…cksprovider/delivery_requester

Signed-off-by: Amrit Prakash <[email protected]>
Signed-off-by: Amrit Prakash <[email protected]>
fix premature timeout of rpc connection during test

fix premature timeout of rpc connection during test

Signed-off-by: Amrit Prakash <[email protected]>

select {
case <-timer.C:
ds.t.Fatalf("timed out waiting for seek assertions to receive a value\n")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be t.Fatal() rather than t.Fatalf()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
This PR is incomplete. Please move it to draft until you finish or tag it as WIP.

  • Please don't remove the tests that use mocks, just add tests that communicate with a real grpc server
  • Send a seek info message and check it is received
  • Respond with a block and check it is received
  • Check connecting with TLS and connection errors

@solo-daemon solo-daemon marked this pull request as draft May 8, 2024 13:51
@Williams23678
Copy link

Hello how to access free bitcoin

@Williams23678
Copy link

Is it possible to access bitcoin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BFT Block Puller: unit test the DeliveryRequester
3 participants