Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add back Coveralls coverage tool #5215

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

BAStos525
Copy link
Contributor

@BAStos525 BAStos525 commented Nov 1, 2024

Context

llvm-cov coverage doesn't work with SonarQube.

Solution

Add Action to upload coverage report to Coveralls.

  • I've read CONTRIBUTING.md.
  • (optional) I've written unit tests for the code changes.
  • All review comments have been resolved.
  • All CI checks pass.

mversic
mversic previously approved these changes Nov 1, 2024
mversic
mversic previously approved these changes Nov 2, 2024
@BAStos525
Copy link
Contributor Author

BAStos525 commented Nov 2, 2024

Blocked by codecov/codecov-action#1602

I'll try Coveralls

@BAStos525 BAStos525 marked this pull request as draft November 2, 2024 15:13
@BAStos525 BAStos525 changed the title ci: Add back Codecov coverage tool ci: Add back Coveralls coverage tool Nov 2, 2024
@BAStos525 BAStos525 closed this Nov 2, 2024
@BAStos525 BAStos525 deleted the i2/ci-codecov branch November 2, 2024 15:56
@BAStos525 BAStos525 restored the i2/ci-codecov branch November 2, 2024 15:57
@BAStos525 BAStos525 reopened this Nov 2, 2024
@BAStos525 BAStos525 marked this pull request as ready for review November 2, 2024 15:57
@BAStos525 BAStos525 requested a review from mversic November 2, 2024 15:57
@s8sato s8sato self-assigned this Nov 5, 2024
.github/workflows/iroha2-dev-pr.yml Show resolved Hide resolved
@nxsaken nxsaken requested a review from DCNick3 as a code owner November 6, 2024 07:39
@nxsaken nxsaken merged commit eee9449 into hyperledger-iroha:main Nov 6, 2024
14 of 19 checks passed
@BAStos525 BAStos525 deleted the i2/ci-codecov branch November 7, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants