refactor: fix application of the core chain-wide parameters; chores #4697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on #4516, I experimented with extreme reduction of consensus timings, i.e.
block_time
andcommit_time
. Those are configured byNewParameter
andSetParameter
ISIs (until #4028). It turned out that there are a few issues iniroha_core
:DEFAULT_CONSENSUS_ESTIMATION
(4 seconds) for no reason, leading to some bugs, e.g. improper time triggers execution. I made it rely on the values in the actual State config.So, this PR "tightens" these gaps and makes parameters application preciser.
This PR doesn't introduce changes to the tests themselves, as I am still experimenting with it.
Linked issue
None
Benefits
More expected behaviour of the chain-wide parameters.