Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split WS client from server #87

Merged
merged 16 commits into from
Nov 21, 2024
Merged

Split WS client from server #87

merged 16 commits into from
Nov 21, 2024

Conversation

adam-fowler
Copy link
Member

@adam-fowler adam-fowler commented Nov 12, 2024 •
edited
Loading

  • Create new targets WSCore, WSClient and WSCompression and move code into these targets
  • Export symbols from these targets in the original Hummingbird targets
  • Move WSCore, WSClient and WSCompression into separate package swift-websocket.
  • Make this package dependent on swift-websocket.
  • Do release of swift-websocket and use released version

@adam-fowler adam-fowler marked this pull request as draft November 12, 2024 09:00
@adam-fowler adam-fowler marked this pull request as ready for review November 15, 2024 16:47
@adam-fowler adam-fowler merged commit a382c7d into main Nov 21, 2024
3 of 5 checks passed
@adam-fowler adam-fowler deleted the split-ws-client branch November 21, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joannis Joannis Joannis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adam-fowler @Joannis