Skip to content
This repository has been archived by the owner on Mar 30, 2018. It is now read-only.

Wrong error message when composer.phar do not exists on custom config path. #170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yvoyer
Copy link

@yvoyer yvoyer commented Feb 27, 2016

This issue was caused, when the following steps are encountered:

  • When the composer.phar do not exists at the root
  • composer.json file defines a different path to the bin

composer.json ie.

    "require-dev": {
        "humbug/humbug": "~1.0@dev"
    },
    "config": {
        "bin-dir": "bin/"
    }

When this happens, and you run humbug, we get the following error:

[Humbug\Exception\RuntimeException]                                                    
  Unable to locate a PHPUnit executable on local system. Ensure that PHPUnit is installed and available.

Putting the composer finder outside the try catch, now show the right errors about the composer missing.

@yvoyer
Copy link
Author

yvoyer commented Feb 27, 2016

@padraic, I'm not sure why travis builds do not pass, while on my machine it does. Do you have a composer installed globally?

* Error message is now warning about composer missing, instead of PHPunit missing.
@yvoyer yvoyer force-pushed the bugfix/warn-when-composer-not-installed branch from 9dcf16b to fd0bfd7 Compare February 27, 2016 13:54
@theofidry theofidry added this to the 1.0.0 milestone Apr 19, 2017
Copy link
Collaborator

@padraic padraic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be rechecked to current master and/or with composer installed in various ways (per issue description) to see if reported issue can be reproduced.

With conflicts resolved, the current PR produces composer not found RuntimeExceptions for 7 behat scenarios.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants