Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use native docker actions for docker mult-arch build #3180

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use native docker actions for docker mult-arch build #3180

wants to merge 1 commit into from

Conversation

adamus1red
Copy link

  • Add setup-qemu and setup-buildx actions to give docker the ability to build multiple architecture builds
  • Remove call to ./build_docker_image.sh
  • Replace docker build script with build-push action from docker.
  • Add basic metadata tagging.

REF: #2648

@adamus1red
Use native docker actions for docker mult-arch build (#1)
46694cd 
* Add setup-qemu and setup-buildx actions to give docker the ability to build multiple architecture builds
* Remove call to `./build_docker_image.sh` 
* Replace docker build script with build-push action from docker.
* Add basic metadata tagging.

REF: huginn#2648
@Macleykun Macleykun mentioned this pull request Nov 13, 2022
Closed
knu
knu reviewed Dec 22, 2022
View reviewed changes
Copy link
Member

@knu knu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Somehow a CI build against a PR is not working, but I think I need to try this out.

.github/workflows/ci.yml
push: ${{ github.event_name != 'pull_request' && env.GITHUB_REF_NAME == 'master' }}
platforms: ${{ env.PLATFORMS }}
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
Copy link
Member

@knu knu Dec 22, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please end the file with an EOL.

@MarioRicalde MarioRicalde mentioned this pull request Aug 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knu knu knu left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adamus1red @knu