Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

botonic-react: some little changes using typescript #2950

Open
wants to merge 8 commits into
base: botonic-react/header-with-typescript
Choose a base branch
from
Open

botonic-react: some little changes using typescript #2950

wants to merge 8 commits into from

Conversation

Iru89
Copy link
Contributor

@Iru89 Iru89 commented Dec 18, 2024 •
edited
Loading

Description

Review commit to commit for more context
In this PR are several small changes that were missing from previous PRs.

Significant changes

  • the useWebchat already exports the closeWebchat function and repliesRef
  • in the useScrollController checks repliesRef.current

With these changes all tests pass

@Iru89 Iru89 changed the title Botonic react/fix some types botonic-react: some little changes using typescript Dec 18, 2024
@Iru89 Iru89 marked this pull request as ready for review December 18, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanbasten17 vanbasten17 vanbasten17 approved these changes

@asastre asastre Awaiting requested review from asastre

@alexgimenez02 alexgimenez02 Awaiting requested review from alexgimenez02

@AinaVendrell AinaVendrell Awaiting requested review from AinaVendrell

@AlbertGom AlbertGom Awaiting requested review from AlbertGom

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Iru89 @vanbasten17