botonic-react: Webchat component with typescript #2947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iru89
force-pushed
the
botonic-react/webchat-typescript
branch
6 times, most recently
from
731daba to
781cd5f
Compare
Iru89
changed the title
…d functions and some action in reducer
Iru89
force-pushed
the
botonic-react/webchat-typescript
branch
from
781cd5f to
a343882
Compare
Iru89
requested review from
asastre,
vanbasten17,
alexgimenez02,
AinaVendrell and
AlbertGom
vanbasten17
approved these changes
Dec 18, 2024
AinaVendrell
approved these changes
Dec 20, 2024
| }>({ | ||
| closeWebview: async () => undefined, | ||
| getString: () => '', | ||
| getString: undefined, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use typescript in the webchat file, there are still not all the correct types, there are some any and some @ts-ignore that will have to be checked in the future.
Check commit by commit, the first commit only changes the extension of the webchat file from jsx to tsx so in the following commits you can see the changes applied.
In the following PRs more components and files are passed to typescript