botonic-react: WebchatApp with typescript #2945
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanbasten17
reviewed
Dec 10, 2024
…nd server as undefined
Iru89
requested review from
asastre,
alexgimenez02,
AinaVendrell,
AlbertGom and
vanbasten17
vanbasten17
approved these changes
Dec 18, 2024
AinaVendrell
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Review commit by commit, on the first commit only change extension to
.tsxin the next commits can view the real changesContext
The goal is to have all the code from @botonic/react in typescript to reduce errors when refactoring a feature.
I have updated the webchat-app file to tsx creating the necessary interfaces for WebchatAppProps and WebchatRef.
I have also refactored a little bit the types used in hubtype-services inside @botonic-core as some of the fields can be undefined.
Approach taken / Explain the design
To document / Usage example
Testing
The pull request...