Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssh keys fields on meta API response #1996

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

jonesbusy
Copy link
Contributor

Description

GitHub added in 2022 those fields on the meta API

I have an application I need to retrieve those public keys have a manual verification before closing repositories (using Apache Mina)

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.23%. Comparing base (58dcca1) to head (15b0239).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1996   +/-   ##
=========================================
  Coverage     83.23%   83.23%           
- Complexity     2350     2352    +2     
=========================================
  Files           233      233           
  Lines          7223     7225    +2     
  Branches        379      379           
=========================================
+ Hits           6012     6014    +2     
  Misses          973      973           
  Partials        238      238           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitwiseman bitwiseman merged commit 4f505a5 into hub4j:main Dec 18, 2024
12 checks passed
@jonesbusy jonesbusy deleted the feature/public-keys-meta-api branch December 18, 2024 19:05
@jonesbusy
Copy link
Contributor Author

Thanks for the merge @bitwiseman

Is other releases for 1.x line are expected or future enhancement will go on 2.x ?

I'm personnally fine with both, I already tested the 2.x alpha on my app and no issue so far

Happy holidays

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants