-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Scanning API support #1787
base: main
Are you sure you want to change the base?
Conversation
f9767a5
to
10d3458
Compare
Hi @bitwiseman, tagging you here because you're the only member of the hub4j org that I can see. When you get the chance, could you approve the test workflows on this PR? The tests are passing locally, but I want to make sure things are all good in CI before I open up for review. It'd also be great to get access to the security alerts in the hub4j-test-org so that I can refresh the wiremock snapshots. Thanks! |
c20ace1
to
62361a5
Compare
@wwong |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1787 +/- ##
============================================
- Coverage 81.05% 81.02% -0.04%
- Complexity 2442 2476 +34
============================================
Files 237 242 +5
Lines 7342 7456 +114
Branches 398 412 +14
============================================
+ Hits 5951 6041 +90
- Misses 1145 1155 +10
- Partials 246 260 +14 ☔ View full report in Codecov by Sentry. |
@bitwiseman Thanks! I'll see if I can find some time this weekend to shore up the code coverage and add some more support for the rest of the Code Scanning endpoints. |
3 methods added - 1 with no filter, 1 with state filter and 1 with tool name filter. [hub4j#1133]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream changes to test data.
...gAlertInstanceTest/wiremock/testListAlertInstances/mappings/repos_hub4j-test-org_pixi-2.json
Outdated
Show resolved
Hide resolved
...remock/testListAlertInstances/mappings/repos_hub4j-test-org_pixi_code-scanning_alerts-3.json
Outdated
Show resolved
Hide resolved
...istAlertInstances/mappings/repos_hub4j-test-org_pixi_code-scanning_alerts_1_instances-4.json
Outdated
Show resolved
Hide resolved
.../github/GHCodeScanningAlertInstanceTest/wiremock/testListAlertInstances/mappings/user-1.json
Outdated
Show resolved
Hide resolved
...canningAlertTest/wiremock/testGetCodeScanningAlert/mappings/repos_hub4j-test-org_pixi-2.json
Outdated
Show resolved
Hide resolved
...ohsuke/github/GHCodeScanningAlertTest/wiremock/testGetCodeScanningAlert/mappings/user-1.json
Outdated
Show resolved
Hide resolved
...suke/github/GHCodeScanningAlertTest/wiremock/testListCodeScanningAlerts/mappings/user-1.json
Outdated
Show resolved
Hide resolved
...ck/testListCodeScanningAlerts/mappings/repos_hub4j-test-org_pixi_code-scanning_alerts-4.json
Outdated
Show resolved
Hide resolved
...ck/testListCodeScanningAlerts/mappings/repos_hub4j-test-org_pixi_code-scanning_alerts-3.json
Outdated
Show resolved
Hide resolved
...nningAlertTest/wiremock/testListCodeScanningAlerts/mappings/repos_hub4j-test-org_pixi-2.json
Outdated
Show resolved
Hide resolved
@wwong |
Will do, thanks @bitwiseman. Life is a little busy right now, but I hope to get back to this soon, maybe in the next couple weeks. In the process of integrating these changes in a work project, I also found some areas for improvement in the proposed code scanning interfaces, which I'll also try to incorporate before finalizing the PR. |
Description
Following up on open comments from #1142 and cortexapps#8
I don't currently have access to the security alerts for the example test repo (https://github.com/hub4j-test-org/Pixi), so the response fields might be slightly outdated until I (or someone else) can re-record the wiremock samples.
Start of an (incomplete) implementation for #1133 (will add more endpoints in a later PR)
This change adds the read-only calls for the following endpoints, as they were originally implemented in previous PRs:
Before submitting a PR:
@link
JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install site
locally. If this command doesn't succeed, your change will not pass CI.main
. You will create your PR from that branch.When creating a PR: