Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #306 - use HTTP Connect when working via proxy #373

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

biancazzurri
Copy link

No description provided.

…ing SSL data via proxy, reuse handshook connections

(cherry picked from commit 6a1aa8049214d8ede3a448ceb6f2ef7b13a7c626)
@ptaoussanis
Copy link
Member

@biancazzurri Hi Roman, this looks really promising- thank you!

Could you give me some idea how extensively this has been tested/used in production, etc.? What's your level of confidence re: readiness to merge?

(Asking since it's not a trivial change, and want to have some idea how extensively you think this should be reviewed before merging).

Cheers :-)

@biancazzurri
Copy link
Author

biancazzurri commented May 5, 2018

@ptaoussanis
Hey, Peter

This was not tested in production since we found another solution :)
I think what should be done is a stress testing, sending requests for a couple of hours to several http and https sites via proxy and directly, and use a profiler to see if some leaks are present. I am ready to do that, but before that I wanted someone else to look at the code.
Before another solution for our problem was found I checked this with my use case - AWS ELB which redirects request to a swarm of proxies, and it was cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants