Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inefficient regular expressions in code #1147

Open
coliff opened this issue Sep 6, 2022 · 4 comments
Open

Fix inefficient regular expressions in code #1147

coliff opened this issue Sep 6, 2022 · 4 comments
Labels
help wanted We are looking for community help keep-unstale The issue will not be marked as stale by the stale-bot

Comments

@coliff
Copy link
Member

coliff commented Sep 6, 2022

REF: https://lgtm.com/projects/g/htmlhint/HTMLHint/?mode=list

There are a number of Inefficient regular expressions and other related issues in the codebase.

PRs are welcome!
@coliff coliff added the help wanted We are looking for community help label Sep 6, 2022
@nschonni
Copy link
Contributor

nschonni commented Sep 6, 2022

Think they can also be seen https://github.com/htmlhint/HTMLHint/security/code-scanning

@coliff
Copy link
Member Author

coliff commented Sep 6, 2022

Think they can also be seen htmlhint/HTMLHint/security/code-scanning

Those aren't visible publicly though - only to admins. That's why I linked to LGTM (even though that service is closing down later this year...)

@stale stale bot added the bot:stale Issue marked as stale because there was no activity label Nov 12, 2022
@coliff coliff added bot:stale Issue marked as stale because there was no activity keep-unstale The issue will not be marked as stale by the stale-bot and removed bot:stale Issue marked as stale because there was no activity labels Nov 12, 2022
@htmlhint htmlhint deleted a comment from stale bot Nov 12, 2022
@stale stale bot removed bot:stale Issue marked as stale because there was no activity labels Nov 12, 2022
@bebehr
Copy link

bebehr commented Feb 18, 2024

Think they can also be seen htmlhint/HTMLHint/security/code-scanning

Those aren't visible publicly though - only to admins. That's why I linked to LGTM (even though that service is closing down later this year...)

Are there any active links in 2024 to take a look at them?

@coliff
Copy link
Member Author

coliff commented Feb 19, 2024

@BennyBPB they aren't public still.... but here's a few screengrabs:

image

image

bebehr added a commit to bebehr/HTMLHint that referenced this issue Feb 19, 2024
@bebehr
fix(id-class-value): fix ineficient regex
5163d31 
Replacing the capturing group quantifier ( ... )* with a non-capturing group quantifier (?: ... )*
to reduce the risk of exponential backtracking.

htmlhint#1147
@bebehr bebehr mentioned this issue Feb 20, 2024
Draft
bebehr added a commit to bebehr/HTMLHint that referenced this issue Feb 20, 2024
@bebehr
fix(id-class-value): fix inefficient regex
ea7ea2d 
The positive lookahead assertion `(?= ...)` is used to ensure that the check occurs after the first
lowercase letter and all subsequent characters have been verified to resolve the issue of reference
backtracking

htmlhint#1147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted We are looking for community help keep-unstale The issue will not be marked as stale by the stale-bot
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@coliff @nschonni @bebehr