Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equationally constraint the Example instance of IO to () #859

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sol
Copy link
Member

@sol sol commented Sep 21, 2023

This allows for assertFailure message and throwIO err + at times it might give you slightly better type errors.

However, it's a breaking change as it breaks existing instances of the form:

Instance Example (IO MyTestResult) where
  ...

Questions:

  1. How likely is this to break existing code? Has anybody seen instances of that form in the wild?
  2. Are the benefits tangible enough to make this worthwhile?

@sol sol marked this pull request as ready for review September 21, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant