added task_split_type to project when task splitting complete #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spwoodcock
reviewed
Nov 20, 2023
There was a problem hiding this comment.
This is great. The only thing is that the enum should probably map to a number value for the database.
Check the other enums in the file for reference 😃
But to do this the field would have to be changed to an integer, which would require a migration 🫤
I'll write a migration file for this PR that also includes some other db updates we need (to save making many separate ones), if you could address the enum 👍
|
so we are using int enum for memory efficiency. ok, @spwoodcock i will make it int enum if you could make migration file. |
|
@spwoodcock i have created migration file too please do check it once. |
for more information, see https://pre-commit.ci
spwoodcock
force-pushed
the
task-split-type
branch
from
e8c98c5 to
2b6e873
Compare
nischalstha9
pushed a commit
to naxa-developers/fmtm
that referenced
this pull request
Dec 8, 2023
…osm#990) * fix : added task_split_type to project when task splitting complete * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * changed str enum to int enum * altered field type of task_split_type to integer * created migration file alter-field-type-task_split_type * feat(migration): task_split_type, task_split_dimension, task_num_buildings * fix: add task_split_ params to db_modesl & project schema * fix(migration): creating tasksplittype enum if exists, cast to type * fix: make task_split_type Optional for tests * fix: add task_split_dimension & num_buildings if available --------- Co-authored-by: sujanadh <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: spwoodcock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue #986 the task_split_type field not being saved in the database.
changes: