-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task id on task polygon and feature extracts #976
Conversation
@Sujanadh can you address the looping issue when you get a chance please? I'll merge as soon as you do 👍 |
@spwoodcock @nrjadkry We have a few users using FMTM splitting algorithm to create just the splitted polygons and download the splits and data extracts for each of them. But it seemed that there are no linkages between the splitted polygons and the data extracts that contained within them. They had to manually add columns to the data extract to assign the ids of split polygons to each data extract Requirement They requested if we could generate task ids and also map the task ids to each feature in the data extract that lies under the specific task. |
@susmina94 thanks for the context =) I have no issue with the rationale for the PR, just the implementation is inefficient. I will make the changes I proposed in the code review👍 |
for more information, see https://pre-commit.ci
@spwoodcock i have been working on other issue , i will get to back to this as soon as i complete other one. |
0a2270b
to
4f34e01
Compare
Oh, sorry @Sujanadh - I just made the update 😄 |
* feat: added qr code in task list * added qr code in taskout schema * feat: added task id on task polygon file * feat: added task_id on features extracted file * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * perf: prevent db call for each feat in task geojson * refactor: typo task_id_mapping --> task_feature_mapping --------- Co-authored-by: sujanadh <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: spwoodcock <[email protected]>
fixes #964
added task_id on the task polygon and feature extracts file.