-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter data extract with osm-rawdata (allow custom form upload) #881
Conversation
for more information, see https://pre-commit.ci
Feat osm rawdata pkg
for more information, see https://pre-commit.ci
This requires new release of osm-fieldwork. Config files are updated in the osm-fieldwork. Older config files wont work with these changes. @spwoodcock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sujanadh there is no osm-rawdata in the requirements. Please add that in the pyproject.toml
@nrjadkry ok i added the package. |
DependenciesFor future ref, the lock file also needs to be regenerated for builds to work: cd src/backend
pdm lock It's done automatically if you add the package with: Or install after updating manually: osm-fieldworkI'll make the new osm-fieldwork release tomorrow @nrjadkry and check / merge this PR. Additional notes@Sujanadh on first glance it looks like we remove the UNDERPASS_API_URL config from the code. Can this be added back in anywhere, so it's easily configurable? |
This pull request extracts the data from osm using osm-rawdata package and the output are passed into filter_data in osm_fieldwork in order to filter the data according to the xlsform.
I have another pull request with the same functionality in #877 which was from my fork. I am closing that pull request as all the changes in that pull request are in this one.
closes #509