Feat Remove Microfrontend #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feat-projectinfo-bug
removed fmtm_map micro frontend from docker and github actions
varun2948
added
enhancement
|
Awesome, so the microfrontend has been refactored to a single frontend now? |
spwoodcock
approved these changes
Sep 14, 2023
yeah just took some time to fix it cause it was making so much problem for any other contributors to work on frontend now it will be quite easy @spwoodcock |
|
Great idea to make the code similar and easier to maintain ! |
|
Just found a build issue on fmtm_main will look into it @spwoodcock |
|
The deploy seemed to go ok after I just tweaked dockerfile.prod. Is the error preventing a build for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have removed fmtm_map micro frontend from docker and github actions please verify it @spwoodcock so that it wont break production and development and i have tested it in my local it worked fine.
Btw this PR have also added a feature onto it but you dont have to look all the changes you just have to look onto CONFIGS,DOCKER FILES, GITHUB ACTIONS FILE and ENV.