Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Offline mode button visibility & Basemap component TS type error #1990

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Fix: Offline mode button visibility & Basemap component TS type error #1990

merged 2 commits into from
Dec 13, 2024

Conversation

NSUWAL123
Copy link
Contributor

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation
  • 🧑‍💻 Refactor
  • ✅ Test
  • 🤖 Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

  • Fix offline mode button visibility on specific browsers
  • Fix basemap component TS type

Screenshots

image_720
image_720

@NSUWAL123 NSUWAL123 requested a review from spwoodcock December 13, 2024 04:08
@github-actions github-actions bot added the bug Something isn't working label Dec 13, 2024
spwoodcock
spwoodcock approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@spwoodcock spwoodcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a different prettier / whitespacrle config in your IDE by the way?

It's tricky to review this with all the whitespace changes 😅

@spwoodcock spwoodcock merged commit bc2399d into development Dec 13, 2024
2 checks passed
@spwoodcock spwoodcock deleted the fix/offline-mode-btn-visibility branch December 13, 2024 18:05
@NSUWAL123
Copy link
Contributor Author

I don't think so. Need to look on what's the problem that's causing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spwoodcock spwoodcock spwoodcock approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NSUWAL123 @spwoodcock