Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalise auth setup between frontends #1981

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Finalise auth setup between frontends #1981

merged 2 commits into from
Dec 11, 2024

Conversation

spwoodcock
Copy link
Member

@spwoodcock spwoodcock commented Dec 11, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Follow on from #1974

Describe this PR

  • There were numerous issues in the previous PR.
  • I took the time to do another refactor and finalise the usage across frontends.
  • I tested disabling the debug user, so hopefully better this time πŸ™
  • The frontend debug console was removed in this PR too.

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@spwoodcock
Copy link
Member Author

Merging to get this tested and the release out

@spwoodcock spwoodcock merged commit 1b0ed1b into development Dec 11, 2024
7 of 9 checks passed
@spwoodcock spwoodcock deleted the fix/auth-redo branch December 11, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code bug Something isn't working frontend Related to frontend code
Projects
Development

Successfully merging this pull request may close these issues.

1 participant