Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapper navigation mode integration #1973

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Conversation

NSUWAL123
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

  1. Geolocation dot and orientation arc by default when the page loads
  2. A separate button to go in 'navigation mode':
  • The orientation arc is replaced with an arrow
  • The map pitches to an angle of 50 degrees.
  • The map rotates to match the user's device orientation, with the arrow at the center of the screen all the time.

Screenshots

Screen_Recording_20241210_154637_Chrome.mp4

@NSUWAL123 NSUWAL123 requested a review from spwoodcock December 10, 2024 10:59
@github-actions github-actions bot added the enhancement New feature or request label Dec 10, 2024
@NSUWAL123
Copy link
Contributor Author

Any suggestions on displaying the navigate button better in terms of UX? @spwoodcock @manjitapandey

@spwoodcock
Copy link
Member

spwoodcock commented Dec 10, 2024

Love it!

Instead of a general button on the map for navigation mode, could it be a button inside the feature popup?

We can have two buttons there
'Navigate Here'
'Map In ODK' --> 'Collect Data'

For now, it just enables navigation mode.
In a future PR, it also displays the walking route.

Does that sound OK?

@spwoodcock
Copy link
Member

Also I realise we need a way to disable navigation mode in this case too:

  • A button overlaying the map to say 'Stop Navigation'
  • When the user clicks 'Collect Data' to go to ODK, we also stop the navigation before the redirect

@NSUWAL123
Copy link
Contributor Author

Yeah! Sounds good

@spwoodcock
Copy link
Member

I'll merge this for now, then another PR can add the changes πŸ‘

@spwoodcock spwoodcock merged commit 4af490f into development Dec 10, 2024
2 checks passed
@spwoodcock spwoodcock deleted the feat/mapper-navigation-mode branch December 10, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants