Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit multi additional entities names replacing space with '_' #1926

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

Sujanadh
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

If multiple additional entities are uploaded only the first filename of additional entities is edited to remove space with '_'. This feature is yet to be implemented in UI to allow the uploading of multiple additional entities. Only a single file can be uploaded as an additional entity.

Describe this PR

This PR updates the frontend code to update the filename for multiple additional entities. Some changes have been made to refactor some repeated code and fix the issue of not passing additional entities list when no custom form is uploaded. If additional_entities or custom form is uploaded then it passes payload as a multipart/form-data content type else JSON body.

Screenshots

N/A

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@Sujanadh Sujanadh self-assigned this Nov 29, 2024
@github-actions github-actions bot added bug Something isn't working frontend Related to frontend code labels Nov 29, 2024
@spwoodcock spwoodcock merged commit 51a3e2b into development Nov 29, 2024
5 of 6 checks passed
@spwoodcock spwoodcock deleted the fix/multi-additional-entities branch November 29, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Related to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants