Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basemap control component in mapper frontend + opfs pmtile support (pt1) #1922

Merged
merged 8 commits into from
Nov 28, 2024

Conversation

spwoodcock
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Start towards #1437
Related to #1552 (easy fix in pt2).

Describe this PR

Part 1 of two PRs. In this one I:

  • Add a basemap component to the offline tab.
  • Allows for downloading existing tiles.
  • If mbtiles, then offer download option.
  • If pmtiles, then two options display:
    • Show in map (online).
    • Download to opfs for offline display.
  • Both options use the baselayer switcher.
  • The pmtile layer is added as a baselayer to select.

In pt2 I will:

  • Update the file path storage for basemaps in the db.
  • Migrate all existing basemaps to S3.
  • Populate the url field correctly with the S3 URL.
  • Possibly also rename all.pmtiles opfs file to offline.pmtiles?

Review Guide

  • Create a pmtiles archive on management (react) frontend.
  • Go to mapper frontend offline tab.
  • View the options there.
  • Select pmtiles, then display.
  • Select mbtiles, then download.

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@spwoodcock spwoodcock requested a review from NSUWAL123 November 27, 2024 18:10
@spwoodcock spwoodcock self-assigned this Nov 27, 2024
@github-actions github-actions bot added enhancement New feature or request frontend Related to frontend code tests Related to automated code tests labels Nov 27, 2024
@spwoodcock spwoodcock merged commit 4351665 into development Nov 28, 2024
6 checks passed
@spwoodcock spwoodcock deleted the feat/mapper-pmtiles branch November 28, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Related to frontend code tests Related to automated code tests
Projects
Development

Successfully merging this pull request may close these issues.

2 participants