Add tests for submission routes

[Anuj-Gupta4]

What type of PR is this? (check all applicable)

• 🍕 Feature
• 🐛 Bug Fix
• 📝 Documentation
• 🧑‍💻 Refactor
• ✅ Test
• 🤖 Build or CI
• ❓ Other (please specify)

Related Issue

Example: Resolves #1913

Describe this PR

A fixture for submission has been created and some tests have been added for submission routes.

Checklist before requesting a review

• 📖 Read the FMTM Contributing Guide: https://github.com/hotosm/fmtm/blob/main/CONTRIBUTING.md
• 📖 Read the HOT Code of Conduct: https://docs.hotosm.org/code-of-conduct
• 👷‍♀️ Create small PRs. In most cases, this will be possible.
• ✅ Provide tests for your changes.
• 📝 Use descriptive commit messages.
• 📗 Update any related documentation and include any relevant screenshots.

[spwoodcock]

I love that this adds another test, so going to approve after minor fixes 👍

There's definitely more scope to test the different submission download types after, like CSV and geojson (this is in a different endpoint I think).

But I just wanted to comment that using basic auth via requests auth= isn't great. I'm surprised that ODK Central accepts this & support could possibly be removed in the future. In osm-fieldwork we have wrappers for the Central API (as does pyodk). Both of those libraries handle Central authentication via the sessions API (request a session token, then use the token to authenticate).

It's still a good PR though! 💫

[Anuj-Gupta4]

@spwoodcock
Should I add more tests for submission routes?

I wonder if i should simply make another api call to replace the basic auth with session authentication using:
https://docs.getodk.org/central-api-authentication/#using-the-session

[spwoodcock]

No need for that if this approach works 😄

I think it would be more valuable adding pyodk as a dependency in FMTM, as it might be useful elsewhere anyway:

uv add pyodk

The submission could be created with the pyodk client, then more tests written for json CSV and geojson downloads =)

I'll leave you to assess how much time this may take though and if it's worth it. Requirements relates to Tokha could be addressed instead if this will take a long time 👍 Either way is fine!

[Anuj-Gupta4]

I haven't included the .pyodk_config.toml file in tests directory.

[spwoodcock]

As the credentials are only used for testing, it's ok to commit that file. I think we need it for the tests to work (pyodk doesn't accept environment variables unfortunately 🥲)

[spwoodcock]

This is excellent, well done!

Two tiny changes and all good to merge

[spwoodcock]

Sorry Anuj! I didn't mean the dev server credentials!

The credentials you can use are for the locally installed version of ODK Central, which always has user [email protected] and password Password1234. The URL is https://proxy (which resolves to the proxy container, and then forwards traffic to the ODK Central container over HTTPS)

[Anuj-Gupta4]

Oops my bad.