fix(+page): mobile broser map control placement fix #1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spwoodcock
requested changes
Nov 19, 2024
There was a problem hiding this comment.
First time learning about dvh today! Dynamic vertical height, cool!
I was reading about it
https://dev.to/frehner/css-vh-dvh-lvh-svh-and-vw-units-27k4
Looks like dvh may not be ideal due to user experience and performance. Perhaps we should try svh? 🙏
spwoodcock
pushed a commit
that referenced
this pull request
Nov 27, 2024
* fix(+page): mobile broser map control placement fix * fix(+page): replace dvh with svh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
The legend & base-layer switcher is partially hidden by the tab options.
Describe this PR
Screenshots