Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): update check_access logic to allow checking for org_man… #1892

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

spwoodcock
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Follow on from #1845

Describe this PR

  • Project creation is broken, as some endpoints do not take an org_id param.
  • Instead they accept a project_id param, so we need an updated check_access function to account for this.

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@spwoodcock spwoodcock added bug Something isn't working priority:critical Blocking current tasks or user workflow backend Related to backend code effort:low Likely a few hours labels Nov 18, 2024
@spwoodcock spwoodcock self-assigned this Nov 18, 2024
@spwoodcock spwoodcock merged commit ef91d88 into development Nov 18, 2024
2 of 3 checks passed
@spwoodcock spwoodcock deleted the fix/org-manager branch November 18, 2024 00:22
Copy link
Contributor

@Anuj-Gupta4 Anuj-Gupta4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code bug Something isn't working effort:low Likely a few hours priority:critical Blocking current tasks or user workflow
Projects
Development

Successfully merging this pull request may close these issues.

2 participants