Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update permissions for backend project routes #1885

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

spwoodcock
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Describe this PR

  • I didn't realise we didn't have roles set on some project endpoints.
  • This PR ensures login is required for all endpoints, to prevent spamming of the API by scrapers etc.
  • I also ordered the large projects_routes file into sections, for mapper, manager, and org admin roles.
  • Also adds a fix for the fmtm.dev.test domain in the updated CORS orgins logic: allows Playwright tests to succeed & deployment to happen.

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@spwoodcock spwoodcock added priority:high Should be addressed as a priority backend Related to backend code effort:low Likely a few hours labels Nov 14, 2024
@spwoodcock spwoodcock requested a review from Sujanadh November 14, 2024 11:30
@spwoodcock spwoodcock self-assigned this Nov 14, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 14, 2024
@spwoodcock
Copy link
Member Author

Merging early to get the mapper frontend deployment out asap

@spwoodcock spwoodcock merged commit 431ccc3 into development Nov 14, 2024
5 checks passed
@spwoodcock spwoodcock deleted the fix/project-api-permissions branch November 14, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code bug Something isn't working effort:low Likely a few hours priority:high Should be addressed as a priority
Projects
Development

Successfully merging this pull request may close these issues.

1 participant