Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pwa in manager frontend with dummy service worker (prep for removal) #1874

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

spwoodcock
Copy link
Member

@spwoodcock spwoodcock commented Nov 12, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Describe this PR

  • The caching from the PWA on the manager frontend prevents loading the /mapnow/ID/ URLs for the mapper frontend.
  • We don't actually need a PWA for the manager frontend anymore - this will eventually be transferred to the mapper frontend only.
  • To facilitate this I added configure to create a dummy service worker that's purpose is to unregister the old service worker.
  • Users that visit FMTM will have the PWA service worker removed, so they can correctly load the mapper frontend.
  • Later on, the PWA can be removed entirely (once this is pushed through to prod and most users have unregistered the old service worker / or had it expire).

@manjitapandey hopefully the fix for your demo tomorrow πŸ‘

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

this is used to unregister the existing sw, preparation to complete removal
@spwoodcock spwoodcock added priority:critical Blocking current tasks or user workflow frontend Related to frontend code devops Related to deployment or configuration effort:low Likely a few hours labels Nov 12, 2024
@spwoodcock spwoodcock self-assigned this Nov 12, 2024
@spwoodcock spwoodcock merged commit 704146b into development Nov 12, 2024
6 checks passed
@spwoodcock spwoodcock deleted the build/remove-pwa branch November 12, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Related to deployment or configuration effort:low Likely a few hours frontend Related to frontend code priority:critical Blocking current tasks or user workflow
Projects
Development

Successfully merging this pull request may close these issues.

1 participant