Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update project xlsform SQL after backend refactor #1872

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

Sujanadh
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

This PR fixes the mentioned issue.

changes

  • Changed Insert command to Update command to update the form of the existing project
  • Added new field author_id (NOT NULL constraints)
  • Changed return response from project data to simple success message
  • Update response in Frontend

Screenshots

N/A

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@Sujanadh Sujanadh requested a review from spwoodcock November 12, 2024 09:37
@Sujanadh Sujanadh self-assigned this Nov 12, 2024
@github-actions github-actions bot added bug Something isn't working frontend Related to frontend code backend Related to backend code labels Nov 12, 2024
@spwoodcock spwoodcock changed the title Fix update project form Fix update project xlsform SQL after backend refactor Nov 13, 2024
@spwoodcock spwoodcock merged commit 510dfb0 into development Nov 13, 2024
9 checks passed
@spwoodcock spwoodcock deleted the fix/update-form branch November 13, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code bug Something isn't working frontend Related to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants