Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Project Creation Wordings #1858

Merged
merged 8 commits into from
Nov 18, 2024
Merged

Conversation

NSUWAL123
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (Terminology update, descriptions add)

Related Issue

Describe this PR

This PR contains the following works:

  • Note add of EPSG:4326 coordinate system on upload area step of create project
  • Update Select Category terminology

Screenshots

image
image

@github-actions github-actions bot added bug Something isn't working frontend Related to frontend code tests Related to automated code tests labels Nov 8, 2024
@spwoodcock
Copy link
Member

Don't forget the stepper header too πŸ˜‰

I think 'Upload Survey' is a good name. Possibly we could change the tab name in the code to match too?

Copy link
Member

@spwoodcock spwoodcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably avoid the word 'form' in anything user facing πŸ˜„

@@ -16,7 +16,7 @@ import useDocumentTitle from '@/utilfunctions/useDocumentTitle';
import { Loader2 } from 'lucide-react';

const SelectForm = ({ flag, geojsonFile, customFormFile, setCustomFormFile }) => {
useDocumentTitle('Create Project: Select Category');
useDocumentTitle('Create Project: Select Form');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be better as 'Upload Survey'

@@ -64,7 +63,7 @@ const UploadArea = ({ flag, geojsonFile, setGeojsonFile, setCustomDataExtractUpl
}
dispatch(CreateProjectActions.SetIndividualProjectDetailsData(formValues));
dispatch(CommonActions.SetCurrentStepFormStep({ flag: flag, step: 3 }));
navigate('/select-category');
navigate('/select-form');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, possibly 'upload-survey' πŸ‘

@NSUWAL123 NSUWAL123 marked this pull request as ready for review November 18, 2024 09:52
@NSUWAL123 NSUWAL123 requested a review from spwoodcock November 18, 2024 09:52
@spwoodcock spwoodcock merged commit 35b1cf1 into development Nov 18, 2024
6 checks passed
@spwoodcock spwoodcock deleted the fix/project-creation-wordings branch November 18, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Related to frontend code tests Related to automated code tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants