Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualize submission photos on frontend #1857

Merged

Conversation

NSUWAL123
Copy link
Contributor

@NSUWAL123 NSUWAL123 commented Nov 6, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

This PR contains API integration of submission photos API & image-slider component to visualize submission photos on the frontend.

Screenshots

image_720
image_720
image

@NSUWAL123 NSUWAL123 requested a review from spwoodcock November 6, 2024 11:28
@github-actions github-actions bot added enhancement New feature or request frontend Related to frontend code labels Nov 6, 2024
@NSUWAL123
Copy link
Contributor Author

Theres a problem with the API where it returns an empty list although photos are uploaded. Sujan is addressing the issue now. Will mark this PR ready for review once its solved and tested on the frontend.

@NSUWAL123 NSUWAL123 marked this pull request as ready for review November 8, 2024 06:38
@NSUWAL123
Copy link
Contributor Author

@spwoodcock this PR is good to be merged

@spwoodcock spwoodcock merged commit f629087 into hotosm:development Nov 11, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Related to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants