Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix s3 upload and db insertion for submission photos #1856

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

Sujanadh
Copy link
Contributor

@Sujanadh Sujanadh commented Nov 6, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Issues:-

Describe this PR

This PR updates the missing parameter "db" for the background task to upload submission in s3 and the command to execute batch insertion of submission photos in db. It also fixes the get API of submission photos using submission_id making db id Optional. There is a slight change in the payload for the task split by square from dimension to dimension_meters which fixes the issue of splitting by square.

Response

{
  "image_urls": [
    "http://s3.fmtm.localhost:7050/fmtm-data/1/2/uuid:7d485b1b-7b2c-4bf0-afcf-d5e0ab585070/1.jpeg"
  ]
}

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@Sujanadh Sujanadh added bug Something isn't working backend Related to backend code effort:low Likely a few hours labels Nov 6, 2024
@Sujanadh Sujanadh requested a review from spwoodcock November 6, 2024 09:16
@Sujanadh Sujanadh self-assigned this Nov 6, 2024
@github-actions github-actions bot added the frontend Related to frontend code label Nov 6, 2024
@spwoodcock spwoodcock merged commit 11d5430 into development Nov 6, 2024
9 checks passed
@spwoodcock spwoodcock deleted the fix/submission-photos branch November 6, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code bug Something isn't working effort:low Likely a few hours frontend Related to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants