Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SQLAlchemy and replace with async psycopg db driver #1834

Merged
merged 69 commits into from
Oct 25, 2024

Conversation

spwoodcock
Copy link
Member

@spwoodcock spwoodcock commented Oct 24, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Removes SQLAlchemy + GeoAlchemy, fixes #254
Upgrades dependencies, fixes #1664
Upgrade to Python 3.12, fixes #1821

Describe this PR

@rsavoye it finally happened! SQLAlchemy gone πŸ˜„

This is basically a total rewrite of the backend!

  • Removed SQLAlchemy and replaced with fully async psycopg.
  • Deleted a lot of unused logic and generally cleaned up the backend.
  • Upgraded to latest package versions so this FMTM should be in a good place for a long time.
  • Had to refactor the frontend too as a result, renaming some variables for better consistency.
  • Finalise fixing the tests to use async.
  • Finalise testing the frontend and updating variable name changes etc there.

Will handle #1610 in next PR!

Review Guide

Test all the things work!

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

release the kraken!!

@spwoodcock spwoodcock requested a review from Sujanadh October 24, 2024 00:42
@spwoodcock spwoodcock self-assigned this Oct 24, 2024
@github-actions github-actions bot added docs Improvements or additions to documentation enhancement New feature or request frontend Related to frontend code backend Related to backend code devops Related to deployment or configuration migration Contains a DB migration tests Related to automated code tests labels Oct 24, 2024
@spwoodcock spwoodcock changed the title Feat/async db queries v2 Remove SQLAlchemy and replace with async psycopg db driver Oct 24, 2024
@spwoodcock spwoodcock requested a review from NSUWAL123 October 24, 2024 00:44
@spwoodcock
Copy link
Member Author

  • Backend tests working.
  • Due to a change in the enum usage for TaskStatus in the frontend, a bit of functionality is broken.

Going to merge, tackle #1610 first, then update the frontend to use Task Events.

@spwoodcock spwoodcock merged commit 43336bb into development Oct 25, 2024
8 of 9 checks passed
@spwoodcock spwoodcock deleted the feat/async-db-queries-v2 branch October 25, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code devops Related to deployment or configuration docs Improvements or additions to documentation enhancement New feature or request frontend Related to frontend code migration Contains a DB migration tests Related to automated code tests
Projects
None yet
2 participants