Allow empty task id in entity statuses for new geopoint #1822
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
Whenever new geopoint is introduced it won't have task_id since we don't have task_id filter any more so there won't be task id for new feature which resulted into validation error in entity statuses endpoint.
Unrelated to entity statuses , I encountered an issue in
preview_split_by_square
where aoi is changed when single polygon is uploaded.Actual AOI:
After merge_polygons:
Describe this PR
This PR updates the schema
EntityTaskID
andEntityOsmID
in order to allow emptytask_id
andosm_id
which likely occurs if new feature geopoint is introduced in submissions. This PR also updates the functionpreview_split_by_square
where the length of polygon is checked before in order to applymerge_polygons
only for multipolygon aoi.This PR depends on the new release of
osm-fieldwork
for the creation of new entity id for new feature geopoint.Screenshots
N/A
Alternative Approaches Considered
Did you attempt any other approaches that are not documented in code?
Review Guide
Notes for the reviewer. How to test this change?
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?