Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove task_id and task_filter params from XLSForm #1805

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

spwoodcock
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Describe this PR

  • Simplify logic for digitisation and mandatory fields XLSForms based on field feedback.
  • Remove the task_id and task_filter fields to simplify logic.
    • They make it slightly easier to select a geometry by filtering down the available options, at the expense of complicating many things.
    • Ideally the user just selects a geom via intent and doesn't even need to open the map anyway.

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@spwoodcock spwoodcock requested a review from Sujanadh September 23, 2024 21:58
@spwoodcock spwoodcock self-assigned this Sep 23, 2024
@github-actions github-actions bot added enhancement New feature or request frontend Related to frontend code backend Related to backend code labels Sep 23, 2024
@spwoodcock spwoodcock added priority:high Should be addressed as a priority effort:low Likely a few hours and removed enhancement New feature or request frontend Related to frontend code labels Sep 23, 2024
@spwoodcock spwoodcock merged commit d368f03 into development Sep 23, 2024
8 of 9 checks passed
@spwoodcock spwoodcock deleted the refactor/remove-task-filter branch September 23, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code effort:low Likely a few hours priority:high Should be addressed as a priority
Projects
Development

Successfully merging this pull request may close these issues.

1 participant