Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xforms table from database, refactor project creation #1804

Merged
merged 6 commits into from
Sep 23, 2024

Conversation

spwoodcock
Copy link
Member

@spwoodcock spwoodcock commented Sep 23, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Describe this PR

  • Simplified logic during project creation.
  • Added migration to remove xforms table, replacing with projects.odk_form_id an projects.xlsform_content.
  • Previously I thought we might have multiple xlsforms per project, but it's become clear that this is not actually desirable. Instead we just want to map multiple features via the same form; functionality we have almost finished adding.
  • I also removed all remaining XML manipulation, in favour of the new Pandas XLSX editing we have added in osm-fieldwork. I could remove the defusedxml dependency too.

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@spwoodcock spwoodcock added priority:low Backlog of tasks that will be addressed in time backend Related to backend code migration Contains a DB migration effort:low Likely a few hours labels Sep 23, 2024
@spwoodcock spwoodcock requested a review from Sujanadh September 23, 2024 18:58
@spwoodcock spwoodcock self-assigned this Sep 23, 2024
@github-actions github-actions bot added the enhancement New feature or request label Sep 23, 2024
@spwoodcock spwoodcock merged commit a91a734 into development Sep 23, 2024
5 of 6 checks passed
@spwoodcock spwoodcock deleted the refactor/remove-dbxform branch September 23, 2024 19:10
Copy link

sentry-io bot commented Sep 30, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ PanicException: range end index 2 out of range for slice of length 1 app.central.central_crud in append_fields_to_us... View Issue

Did you find this useful? React with a πŸ‘ or πŸ‘Ž

Not sure if this is useful / has been fixed already @Sujanadh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code effort:low Likely a few hours enhancement New feature or request migration Contains a DB migration priority:low Backlog of tasks that will be addressed in time
Projects
Development

Successfully merging this pull request may close these issues.

1 participant