Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pyxform and fix xls extension usage #1789

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

spwoodcock
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Related to #1667

Describe this PR

  • .xlsx was working fine, but .xls caused and error for some reason.
  • Upgraded pyxform to latest, which has a much simpler convert function for XLSForm --> XForm.
  • It attempts to parse XLSX and XLS in order, so we no longer need to pass through the form type.
  • Upgrading also fixed the issue using .xls.

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@spwoodcock spwoodcock self-assigned this Sep 17, 2024
@github-actions github-actions bot added bug Something isn't working backend Related to backend code labels Sep 17, 2024
@spwoodcock spwoodcock merged commit 5c117d6 into development Sep 17, 2024
7 checks passed
@spwoodcock spwoodcock deleted the fix/xls-valid-xlsform branch September 17, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant