Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocation of QR code & Base map layer selection component #1788

Merged
merged 13 commits into from
Sep 17, 2024
Merged

Relocation of QR code & Base map layer selection component #1788

merged 13 commits into from
Sep 17, 2024

Conversation

NSUWAL123
Copy link
Contributor

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation
  • 🧑‍💻 Refactor
  • ✅ Test
  • 🤖 Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

This PR contains the following works done:

  1. Update base map selection popup
  2. Relocate QR code component according to design

Screenshots

image
image

@NSUWAL123
feat(images): add layerIcon images
2165317
@NSUWAL123
feat(layerSwitchMenu): custom layer switcher add
98d4902
@NSUWAL123
fix(mapControlComponent): layerSwitchMenu add to projectDetails mapCo…
6170559 
…ntrolComponent
@NSUWAL123
fix(projectDetailsV2): pmTileLayerData pass to child component
8c946de
@NSUWAL123
fix(mapComponent): customLayer switch add to remaining maps
0ceeabf
@NSUWAL123
fix(layerSwitcherMenu): use radix dropdown to display layerSwitcher
9d241d7
@NSUWAL123
fix(layerSwitcher): rename tileLayer to PMTile, default OL layerSwitc…
d4cdae9 
…her made hidden
@NSUWAL123
fix(projectDetailsV2): shift qrcode placement on bigger screens
736d6c5
@NSUWAL123
fix(mapControlComponent): add tooltips on menus
af41646
@NSUWAL123
fix(projectDetailsV2): add qrcode component on map
6d7ae12
@NSUWAL123
fix(projectDetailsV2): remove legend icon
5abc2c9
@NSUWAL123
fix(layerSwitchMenu): cursordefault remove on layer card
e28e349
@NSUWAL123
Merge branch 'development' of github.com:hotosm/fmtm into fix/project…
7ecf219 
…-details-ui-enhance
@github-actions github-actions bot added bug Something isn't working frontend Related to frontend code labels Sep 17, 2024
@spwoodcock spwoodcock added priority:low Backlog of tasks that will be addressed in time effort:low Likely a few hours labels Sep 17, 2024
@spwoodcock spwoodcock removed priority:low Backlog of tasks that will be addressed in time effort:low Likely a few hours labels Sep 17, 2024
spwoodcock
spwoodcock approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@spwoodcock spwoodcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Good idea updating the layer switcher 💫

@spwoodcock spwoodcock merged commit 01e9fd6 into hotosm:development Sep 17, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spwoodcock spwoodcock spwoodcock approved these changes

Assignees

@NSUWAL123 NSUWAL123

Labels
bug Something isn't working frontend Related to frontend code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NSUWAL123 @spwoodcock