Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] fix pyxform usage only allowing xls file extension #1758

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

spwoodcock
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Fixes #1667

Describe this PR

  • The file extension type was not passed through to pyxform and .xls was hardcoded.
  • Fixed to support .xlsx too.

Review Guide

Test uploading an xlsx file.

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@spwoodcock spwoodcock self-assigned this Aug 20, 2024
@github-actions github-actions bot added bug Something isn't working backend Related to backend code labels Aug 20, 2024
@spwoodcock spwoodcock added the hotfix Code to fix issues in production label Aug 20, 2024
@spwoodcock spwoodcock changed the title Fix pyxform usage only allowing xls file extension [HOTFIX] fix pyxform usage only allowing xls file extension Aug 20, 2024
@spwoodcock spwoodcock merged commit 5b58a8e into development Aug 20, 2024
5 checks passed
@spwoodcock spwoodcock deleted the fix/xlsx-form-parsing branch August 20, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code bug Something isn't working hotfix Code to fix issues in production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix .xlsx XLSForm handling and error messages on failed parse
1 participant