Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade React v18 --> v19 #1545

Merged
merged 8 commits into from
Jun 6, 2024
Merged

Upgrade React v18 --> v19 #1545

merged 8 commits into from
Jun 6, 2024

Conversation

spwoodcock
Copy link
Member

@spwoodcock spwoodcock commented May 31, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Fixes #1544

Describe this PR

  • Upgrade all dependencies to latest version where possible.
  • Upgrade React to v19 release candidate (31/05/2024, with full release in two weeks).
  • Built on Upgrade React v17 --> v18Β #1542, anticipating merge.

Once merged, we can start using Web Components!

TODO once stable is released:

  • Remove overrides section from package.json
  • Update @types/react and @types/react-dom to npm package versions
  • Probably a good idea to run npx codemod@latest react/19/migration-recipe once too

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@spwoodcock spwoodcock added the frontend Related to frontend code label May 31, 2024
@spwoodcock spwoodcock self-assigned this May 31, 2024
@github-actions github-actions bot added docs Improvements or additions to documentation devops Related to deployment or configuration labels May 31, 2024
@spwoodcock spwoodcock force-pushed the feat/upgrade-react-19 branch from 8752971 to 02bf233 Compare June 2, 2024 16:08
@github-actions github-actions bot removed the docs Improvements or additions to documentation label Jun 2, 2024
@spwoodcock spwoodcock marked this pull request as ready for review June 2, 2024 16:11
@spwoodcock spwoodcock requested a review from NSUWAL123 June 2, 2024 16:11
@spwoodcock
Copy link
Member Author

@NSUWAL123 could you please check over the changes in this PR & test the upgrade? πŸ™

I had to replace forwardRef as it's now deprecated, but it's something I have never used before!

@spwoodcock spwoodcock merged commit a338806 into development Jun 6, 2024
4 checks passed
@spwoodcock spwoodcock deleted the feat/upgrade-react-19 branch June 6, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Related to deployment or configuration frontend Related to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade frontend to React v19
1 participant