OPFS-based offline-first PMTile basemaps #1348

spwoodcock · 2024-03-13T19:31:31Z

What type of PR is this? (check all applicable)

Related Issues

None

Describe this PR

Started work on loading PMTile files into browser OPFS storage, then reading when offline.

Finished

Loading the PMTiles archive into OPFS.
Reading the PMTiles into OPFS.
Parsing the PMTiles file as a PMTiles object.

To Do

Assess if the user is offline or not (likely via PWA functionalities).
If user is offline, load the tiles from OPFS to render.
Render the PMTiles in OpenLayers.

@varun2948 @NSUWAL123

Notes

OPFS is unique per domain, so there is no chance of file mixup.
The pmtile archives are for the entire project area, stored under PROJECT_ID/all.pmtiles.

Screenshots

The lightning bolt icon button will download the tiles to OPFS, instead of download directory on filesystem.

Checklist before requesting a review

📖 Read the FMTM Contributing Guide: https://github.com/hotosm/fmtm/blob/main/CONTRIBUTING.md
📖 Read the FMTM Code of Conduct: https://github.com/hotosm/fmtm/blob/main/CODE_OF_CONDUCT.md
👷‍♀️ Create small PRs. In most cases, this will be possible.
✅ Provide tests for your changes.
📝 Use descriptive commit messages.
📗 Update any related documentation and include any relevant screenshots.

[optional] What gif best describes this PR or how it makes you feel?

feat: navigation WIP

Resolved issues on project summaries with no centroids

spwoodcock · 2024-03-18T14:05:16Z

@NSUWAL123 this probably needs a rebase to development to fix the backend 👍

You will also need to docker compose build for it to work!

* feat commonUtils: empty input field validation function * feat projectDetailsValidation: empty input field validation * feat: commonUtils: null & undefined text check * fix organizationDetailsValidation: blank space validation * fix editProjectDetailsValidation: blank space validation

* fix organization: add id to search-organization, skeleton loader bug fix * feat taskSectionPopup: tooltip title add * feat mapControlComponent: tooltip title add * fix generateBasemap: table min width set for mobile view

varun2948 · 2024-03-27T11:08:48Z

I am not used to doing a rebase and u suggested to do a rebase 😆 so i don't know what went wrong i have the same commit going on multiple times .

spwoodcock · 2024-03-27T12:39:33Z

Sorry about that! Sticking with merge is absolutely fine 😄

I'll try and take a look tonight!

Otherwise, in this situation the easiest option may be to just copy the content of the files you have edited to a temp file outside the repo, then reset to the latest development and copy the files back over the top:

# A hard reset will discard files, so be careful with that
# Instead a soft reset will just remove the changes and move them back to staging, which is safer to then delete the files yourself 
git reset --soft development

varun2948 · 2024-03-27T14:20:46Z

will wait for you to do things, if it shows issue will do the one you said. Let me know on anything

spwoodcock · 2024-03-27T16:16:02Z

Replaced by #1395 👍
I kept this branch / PR in case I missed any thing to cherry-pick in.

spwoodcock added 3 commits March 13, 2024 19:27

build: add pmtiles frontend dependency

6fd8150

feat: add functions to read/write opfs pmtiles

9fcfe62

feat(frontend): button to write opfs pmtiles & read again

70ec2fe

spwoodcock added this to the Mobile Mapper Navigation Experience milestone Mar 13, 2024

spwoodcock self-assigned this Mar 13, 2024

github-actions bot added the frontend Related to frontend code label Mar 13, 2024

spwoodcock and others added 11 commits March 14, 2024 11:05

docs: update PR template with review section & alternative approache

06fb7cf

build: add pyxform to dev/stage docker compose setup

3770e29

feat: navigation WIP

6a05fc3

fix: issues on project summaries with no centroids

f1abdee

docs: update pull request template link to code of conduct

74cf97c

Merge pull request #1361 from hotosm/feat-navigation-compass

0f17d43

feat: navigation WIP

Merge pull request #1359 from hotosm/fix/project-summaries

1fc70c7

Resolved issues on project summaries with no centroids

build: add go-pmtiles to dockerfile as workaround

d250100

build: replace pyxform with original package temporarily

aa485c2

fix: workaround for generating pmtiles using go-pmtiles

a885e9a

feat: load opfs pmtiles file into openlayers layerswitcher

8f96bf2

spwoodcock temporarily deployed to test March 18, 2024 12:16 — with GitHub Actions Inactive

github-actions bot added backend Related to backend code devops Related to deployment or configuration labels Mar 18, 2024

spwoodcock temporarily deployed to test March 18, 2024 12:17 — with GitHub Actions Inactive

spwoodcock assigned NSUWAL123 and unassigned spwoodcock Mar 18, 2024

NSUWAL123 and others added 6 commits March 18, 2024 14:10

feat: uploadArea edit AOI btn add (#1346)

bc1ef59

hotfix: enableHighAccuracy true and frequency to 1

a36acfd

feat: navigation icon changes

a0de549

fix: ui for basemap gen, tooltip titles (#1363)

e64cbe5

* fix organization: add id to search-organization, skeleton loader bug fix * feat taskSectionPopup: tooltip title add * feat mapControlComponent: tooltip title add * fix generateBasemap: table min width set for mobile view

test: animation handle

73b2d9c

varun2948 and others added 21 commits March 27, 2024 14:41

fix: react router is acting weird on useblocker FIX ME

3eabacd

fix: long height in generate mbtiles div

f10aac7

build: add pmtiles frontend dependency

31f8fca

feat: add functions to read/write opfs pmtiles

9ca7a43

feat(frontend): button to write opfs pmtiles & read again

ebb8880

build: add go-pmtiles to dockerfile as workaround

310ac36

build: replace pyxform with original package temporarily

1c07709

fix: workaround for generating pmtiles using go-pmtiles

6040fbe

feat: load opfs pmtiles file into openlayers layerswitcher

db2c41e

build: update dockerfile go-pmtiles --> pmtiles binary

ffd13b6

feat: add functions to read/write opfs pmtiles

2133397

feat(frontend): button to write opfs pmtiles & read again

21030c8

build: add go-pmtiles to dockerfile as workaround

410ed8e

build: replace pyxform with original package temporarily

c73b847

feat: load opfs pmtiles file into openlayers layerswitcher

c19e873

build: update dockerfile go-pmtiles --> pmtiles binary

204dcf0

feat: typescript conversion app.jsx and online status added

6ee66f7

feat: pm tiles integration with local file

e396ad4

fix: react router is acting weird on useblocker FIX ME

cdd6fff

fix: long height in generate mbtiles div

9d1fce5

rebasing

d213799

varun2948 temporarily deployed to test March 27, 2024 11:07 — with GitHub Actions Inactive

varun2948 marked this pull request as ready for review March 27, 2024 11:09

spwoodcock closed this Mar 27, 2024

spwoodcock deleted the feat/opfs-pmtiles branch June 7, 2024 11:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OPFS-based offline-first PMTile basemaps #1348

OPFS-based offline-first PMTile basemaps #1348

spwoodcock commented Mar 13, 2024 •

edited

Loading

spwoodcock commented Mar 18, 2024 •

edited

Loading

varun2948 commented Mar 27, 2024

spwoodcock commented Mar 27, 2024

varun2948 commented Mar 27, 2024

spwoodcock commented Mar 27, 2024 •

edited

Loading

OPFS-based offline-first PMTile basemaps #1348

OPFS-based offline-first PMTile basemaps #1348

Conversation

spwoodcock commented Mar 13, 2024 • edited Loading

What type of PR is this? (check all applicable)

Related Issues

Describe this PR

Finished

To Do

Notes

Screenshots

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

spwoodcock commented Mar 18, 2024 • edited Loading

varun2948 commented Mar 27, 2024

spwoodcock commented Mar 27, 2024

varun2948 commented Mar 27, 2024

spwoodcock commented Mar 27, 2024 • edited Loading

spwoodcock commented Mar 13, 2024 •

edited

Loading

spwoodcock commented Mar 18, 2024 •

edited

Loading

spwoodcock commented Mar 27, 2024 •

edited

Loading