Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xform name format for Central + edit form functionality #1310

Merged
merged 9 commits into from
Mar 1, 2024

Conversation

spwoodcock
Copy link
Member

@spwoodcock spwoodcock commented Feb 29, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Issue

Fixes #1275
Fixes #1242

Describe this PR

  • Updates osm-fieldwork --> 0.5.1. OdkForm.form_fields is now called formFields and it returns an error if the request fails @Sujanadh
  • Fixes project creation ODK xform creation with upload media, with caveat ODK Central form media upload fails randomlyΒ #1309
  • Fixes form updating in project update tabs on backend and frontend.
  • Adds extra UI to update the category during form update (mandatory).
  • Removes form categories that either do not work, or are irrelevant to FMTM.
  • Updates project_admin role to return a dict of both the DbProject and DbUser @Sujanadh FYI
  • Added a helper router, with routes for simple helper utils. The one endpoint so far is to fix custom data extracts by adding the correct properties tags before project creation.
  • The logic to add the properties tags was also added to the project creation workflow to automatically do this if the tags are missing from the uploaded geojson.

@varun2948 @nrjadkry feel free to merge this before I start work tomorrow if you are happy with it, so testing can begin.
Sorry for the big PR - I wanted to work fast & got too lazy to split into multiple.

@manjitapandey

Screenshots

image

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@spwoodcock spwoodcock self-assigned this Feb 29, 2024
@github-actions github-actions bot added frontend Related to frontend code backend Related to backend code labels Feb 29, 2024
@spwoodcock spwoodcock changed the title Fix/xform name Fix xform name format for Central + edit form functionality Mar 1, 2024
@spwoodcock spwoodcock merged commit 1b79b20 into development Mar 1, 2024
8 checks passed
@spwoodcock spwoodcock deleted the fix/xform-name branch March 1, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code frontend Related to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some data models for osm data extracts do not work Unable to edit form
1 participant