Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HotFix: Updated the xform in form fields #1298

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

Sujanadh
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Issue

Describe this PR

This PR addresses the updated xform name in the form fields endpoint, solving the crashing issue.

Screenshots

N/A

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@github-actions github-actions bot added the backend Related to backend code label Feb 28, 2024
@Sujanadh Sujanadh self-assigned this Feb 28, 2024
@Sujanadh Sujanadh merged commit 853bdf1 into development Feb 28, 2024
5 checks passed
@spwoodcock spwoodcock deleted the fix/form-fields branch February 29, 2024 08:31
@spwoodcock
Copy link
Member

Nice, thank you πŸ‘

I will cherry pick this commit into staging and main for now.

Just a quick update on the meaning of hotfix @nrjadkry @Sujanadh

A hotfix is to address a high priority bug in production that can't wait until the next deployment cycle.

It's a method to bypass the usual processes of waiting to merge dev --> stage --> main.

So a hotfix should probably be based off the main branch and the PR made to the main branch, if it's a genuine hotfix. In this case I think it is as production could really do with this change (without adding all of the other code on dev that may introduce other bugs).

Another approach could be to make the PR to dev, then cherry pick the commit through to production. But if the code is quite out of sync between dev and main, then this can be more difficult.

@Sujanadh
Copy link
Contributor Author

got it πŸ™Œ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashing of submission table page
2 participants