lower case all event names to get handler class #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with PayPal webhooks I ran into an issue where by handler wasn't getting called as expected.
PayPal uses all uppercase for their event names in webhooks. For example "PAYMENT.AUTHORIZATION.CREATED". See (https://developer.paypal.com/api/rest/webhooks/event-names/).
Because of this, and because my custom provider was passing in the event name unmodified, I discovered it was looking for a class named "PAYMENTAUTHORIZATIONCREATED" instead of "PaymentAuthorizationCreated".
In the meantime I am working around this by lowercasing the event name before returning it from my custom provider, but I feel this should be handled by the package directly because:
Relying the the developer to lowercase event names in their Provider relys on them knowing that is necessary.
I can't imagine a scenario where a developer wants to have an all upperclass class name.
Therefore, this PR lowercases all event names when determining the matching class name.