fix: tableEl undefined

[joaomarr]

No description provided.

[coderabbitai]

Walkthrough

The pull request introduces modifications to the src/components/DataTable/index.vue file, specifically targeting the resizing functionality of table columns. Key changes include the addition of checks to ensure the tableEl reference is defined before executing operations that manipulate its child elements, particularly within the resizeLine and createResizableTable functions. This aims to prevent errors when the table element is unavailable. Furthermore, the createResizableColumn function has been updated to verify the options.value.resize property, ensuring that resizing features are only activated when explicitly enabled. The logic for resizing columns has been consolidated within this function, which now properly initializes resizer elements and attaches event listeners for mouse interactions. Overall, these changes enhance the robustness and stability of the resizing feature without altering the component's overall structure or the declarations of exported entities.

Possibly related PRs

• fix: virtualisation on data table #234: Modifications in this PR also affect the src/components/DataTable/index.vue file, focusing on the rendering logic and structure of the table, which may interact with the resizing functionality introduced in the main PR.
• fix: chores #235: This PR includes updates to the handling of column sizes and resizing functionality in the src/components/DataTable/index.vue file, directly relating to the enhancements made in the main PR regarding the resizing of table columns.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

src/components/DataTable/index.vue (2)

1165-1167: LGTM: Added null check for tableEl reference.

The null check is correctly implemented. However, since this check is identical to the one in resizeLine, consider extracting a helper function to reduce duplication.

+const isTableElAvailable = () => {
+  if (!table.value) {
+    return false;
+  }
+  return true;
+};
+
 const resizeLine = () => {
   if (!options.value.resize) {
     return;
   }
   const tableEl = table.value;
-  if (!tableEl) {
+  if (!isTableElAvailable()) {
     return;
   }
   // ... rest of the function
 };

 const createResizableTable = () => {
   if (!options.value.resize || horizontalScroll.value) {
     return;
   }
   const tableEl = table.value;
-  if (!tableEl) {
+  if (!isTableElAvailable()) {
     return;
   }
   // ... rest of the function
 };

---

Line range hint 1136-1167: Consider extracting resizing logic to a composable.

The table resizing functionality is complex enough to warrant its own composable. This would:

1. Improve code organization
2. Make the resizing feature reusable across other components
3. Make the main component more focused on table rendering
4. Make testing easier

Example structure:

// useTableResize.ts
export function useTableResize(options: {
  table: Ref<HTMLElement | undefined>,
  minColSize: number,
  onResize?: (sizes: string[]) => void
}) {
  // ... resizing logic
  return {
    resizeLine,
    createResizableTable,
    // ... other resize-related functions
  }
}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 067a868 and 7ed8e22.

📒 Files selected for processing (1)

• src/components/DataTable/index.vue (2 hunks)

🔇 Additional comments (1)

src/components/DataTable/index.vue (1)

1136-1138: LGTM: Added null check for tableEl reference.

The addition of this null check prevents potential runtime errors when the table element is not yet available in the DOM.