Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't destroy if pipeline throws an error #83

Merged
merged 3 commits into from
Sep 20, 2023
Merged

fix: don't destroy if pipeline throws an error #83

merged 3 commits into from
Sep 20, 2023

Conversation

yusukebe
Copy link
Member

@yusukebe
Copy link
Member Author

Hey @tangye1234 !

Could you review this PR? Do we need to call outgoing.end()?

@yusukebe yusukebe mentioned this pull request Sep 19, 2023
Closed
@tangye1234
Copy link
Contributor

I thinks this is OK. Thanks.

@yusukebe yusukebe merged commit 63d5e36 into main Sep 20, 2023
3 checks passed
@yusukebe yusukebe deleted the fix/dont-destroy branch September 20, 2023 13:41
@sjc5 sjc5 mentioned this pull request Sep 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERR_STREAM_PREMATURE_CLOSE error
2 participants
@yusukebe @tangye1234