Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate incoming host header #163

Merged
merged 5 commits into from
Apr 19, 2024

Conversation

usualoma
Copy link
Member

@usualoma usualoma commented Apr 19, 2024

fixes #160, #161

What is this?

Validate the content of the host header of the request for security purposes.

Invalid values

If the following values are specified in the host header, a "400 Bad Request" is returned.

  • Empty string (if no default hostname is specified)
  • Including path or query parameter
    • localhost/path localhost?key=value
  • Including invalid charactors
    • localhost<script>

Valid values

Host headers are only validated by character type, so "hostnames with invalid structure" or "hostnames that cannot be looked up" are considered valid and do not result in a "400 Bad Request". For example, the following host headers are considered valid

  • . www...example.com ()

Default hostname

If you also want to accept HTTP 1.0 requests w/o Host header, you can call serve() as follows to ensure that the default hostname is used without error if there is no host header (or an empty string is specified).

serve({
    fetch: app.fetch,
    hostname: 'localhost', // should be associated with the IP address of the server
})

Tasks

  • implement
  • test

@usualoma usualoma force-pushed the fix-invalid-incoming-request-2 branch from 0dd30a9 to aed16dc Compare April 19, 2024 12:22
@usualoma usualoma force-pushed the fix-invalid-incoming-request-2 branch from aed16dc to a24d3ec Compare April 19, 2024 12:24
@usualoma usualoma marked this pull request as ready for review April 19, 2024 13:01
@usualoma
Copy link
Member Author

@yusukebe
Would you please review?

@yusukebe
Copy link
Member

Hi @usualoma

Thank you for handling it. I'll merge this and release the new version right now. The most important thing is to release it first.

@yusukebe yusukebe merged commit 306d98f into honojs:main Apr 19, 2024
3 checks passed
@usualoma usualoma deleted the fix-invalid-incoming-request-2 branch April 19, 2024 20:15
@usualoma
Copy link
Member Author

@yusukebe Thank you!

nicolewhite pushed a commit to autoblocksai/cli that referenced this pull request Apr 29, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@hono/node-server](https://togithub.com/honojs/node-server) |
[`1.10.1` ->
`1.11.1`](https://renovatebot.com/diffs/npm/@hono%2fnode-server/1.10.1/1.11.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@hono%2fnode-server/1.11.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@hono%2fnode-server/1.11.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@hono%2fnode-server/1.10.1/1.11.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@hono%2fnode-server/1.10.1/1.11.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>honojs/node-server (@&#8203;hono/node-server)</summary>

###
[`v1.11.1`](https://togithub.com/honojs/node-server/releases/tag/v1.11.1)

[Compare
Source](https://togithub.com/honojs/node-server/compare/v1.11.0...v1.11.1)

#### What's Changed

- Update Request to work with ReadableStream polyfills by
[@&#8203;nicksrandall](https://togithub.com/nicksrandall) in
[honojs/node-server#164
- refactor(serve-static): use `c.req.path` instead of `url.pathname` by
[@&#8203;yusukebe](https://togithub.com/yusukebe) in
[honojs/node-server#166

#### New Contributors

- [@&#8203;nicksrandall](https://togithub.com/nicksrandall) made their
first contribution in
[honojs/node-server#164

**Full Changelog**:
honojs/node-server@v1.11.0...v1.11.1

###
[`v1.11.0`](https://togithub.com/honojs/node-server/releases/tag/v1.11.0)

[Compare
Source](https://togithub.com/honojs/node-server/compare/v1.10.1...v1.11.0)

#### What's Changed

- feat: validate incoming host header by
[@&#8203;usualoma](https://togithub.com/usualoma) in
[honojs/node-server#163

**Full Changelog**:
honojs/node-server@v1.10.1...v1.11.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" in timezone
America/Chicago, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/autoblocksai/cli).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Determine behaviour for HTTP1.0 request w/o Host header
2 participants