-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix sourcery's suggestions #22
Conversation
Reviewer's Guide by SourceryThis pull request addresses issue #21 by implementing several suggestions from Sourcery to improve the code quality and functionality of the UDict class and its associated tests. The changes include refactoring code for better readability, adding new test cases, and fixing existing ones. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Привет, @bleudev - я просмотрел ваши изменения, и они выглядят отлично!
Вот что я рассмотрел во время проверки
- 🟡 Общие проблемы: найдено 3 проблемы
- 🟢 Безопасность: все выглядит хорошо
- 🟡 Тестирование: найдено 3 проблемы
- 🟢 Сложность: все выглядит хорошо
Sourcery бесплатен для open source - если вам нравятся наши обзоры, пожалуйста, подумайте о том, чтобы поделиться ими ✨
Original comment in English
Hey @bleudev - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 3 issues found
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Мы пропустили проверку этого pull request. Похоже, что мы уже проверили этот pull request.
Original comment in English
We have skipped reviewing this pull request. It looks like we've already reviewed this pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this PR to be merge!
closes #21
Summary by Sourcery
This pull request addresses several issues in the UDict class, including fixing dictionary initialization, item setting logic, length calculation, iteration, and boolean checks. Additionally, new tests have been added to verify these fixes and ensure proper exception handling.