Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UStack #11

Merged
merged 25 commits into from
Jun 7, 2024
Merged

UStack #11

merged 25 commits into from
Jun 7, 2024

Conversation

TheAihopGG
Copy link
Member

@TheAihopGG TheAihopGG commented May 29, 2024

New UStack object

Checklist:

  • UStack object
  • Examples
  • Tests

closes #9

@TheAihopGG
Copy link
Member Author

TheAihopGG commented May 29, 2024

@bleudev, answer

@bleudev
Copy link
Member

bleudev commented May 29, 2024

@TheHakerTech add please unittests. check #3

@bleudev bleudev added new feature New feature new class New class labels May 29, 2024
@bleudev bleudev added this to the 1.0 milestone May 29, 2024
@bleudev bleudev linked an issue May 29, 2024 that may be closed by this pull request
@bleudev bleudev marked this pull request as draft May 29, 2024 08:37
@bleudev bleudev self-requested a review May 29, 2024 08:37
Copy link
Member

@bleudev bleudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very much work is going)

ufpy/ustack.py Outdated Show resolved Hide resolved
ufpy/ustack.py Outdated Show resolved Hide resolved
ufpy/ustack.py Outdated Show resolved Hide resolved
ufpy/ustack.py Outdated Show resolved Hide resolved
ufpy/ustack.py Outdated Show resolved Hide resolved
ufpy/ustack.py Outdated Show resolved Hide resolved
ufpy/ustack.py Outdated Show resolved Hide resolved
ufpy/ustack.py Outdated Show resolved Hide resolved
@bleudev bleudev changed the title Ustack UStack May 29, 2024
@bleudev bleudev added the good first pull Good for newcomers label May 29, 2024
ufpy/ustack.py Outdated Show resolved Hide resolved
ufpy/ustack.py Outdated Show resolved Hide resolved
ufpy/ustack.py Outdated Show resolved Hide resolved
ufpy/ustack.py Outdated Show resolved Hide resolved
ufpy/ustack.py Outdated Show resolved Hide resolved
ufpy/ustack.py Outdated Show resolved Hide resolved
ufpy/ustack.py Outdated Show resolved Hide resolved
ufpy/ustack.py Outdated Show resolved Hide resolved
ufpy/ustack.py Outdated Show resolved Hide resolved
ufpy/ustack.py Outdated Show resolved Hide resolved
ufpy/ustack.py Outdated Show resolved Hide resolved
examples/ustack_in_using.md Outdated Show resolved Hide resolved
examples/ustack_in_using.md Outdated Show resolved Hide resolved
examples/ustack_in_using.md Outdated Show resolved Hide resolved
ufpy/ustack.py Outdated Show resolved Hide resolved
ufpy/ustack.py Outdated Show resolved Hide resolved
ufpy/ustack.py Outdated Show resolved Hide resolved
ufpy/ustack.py Show resolved Hide resolved
Copy link
Member

@bleudev bleudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good with UStack realisation!

tests/ustack_in_use.md Outdated Show resolved Hide resolved
tests/ustack_in_use.md Outdated Show resolved Hide resolved
tests/ustack_in_use.md Outdated Show resolved Hide resolved
ufpy/__init__.py Show resolved Hide resolved
@bleudev bleudev marked this pull request as ready for review June 4, 2024 21:37
@bleudev bleudev marked this pull request as draft June 4, 2024 21:38
Copy link
Contributor

sourcery-ai bot commented Jun 4, 2024

Reviewer's Guide by Sourcery

This pull request introduces a new UStack object and makes several other significant changes, including the addition of the UDict class, examples, and tests. The changes are implemented by adding new files and modifying existing ones to support the new functionality.

File-Level Changes

Files Changes
ufpy/udict.py
examples/udict.md
tests/test_udict.py
Introduced the UDict class along with its documentation and unit tests.
ufpy/ustack.py
tests/ustack_in_use.md
Introduced the UStack class along with its documentation and examples.
ufpy/math_op.py
ufpy/cmp.py
Added utility decorators for generating in-place, reverse, and comparison operations.
ufpy/typ/protocols.py
ufpy/utils.py
ufpy/typ/type_alias.py
Added protocol definitions, utility functions, and type aliases for enhanced type handling.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Привет @TheHakerTech - я просмотрел ваши изменения, и они выглядят отлично!

Вот что я рассмотрел во время проверки
  • 🟡 Общие проблемы: найдено 9 проблем
  • 🟢 Безопасность: все выглядит хорошо
  • 🟡 Тестирование: найдено 6 проблем
  • 🟢 Сложность: все выглядит хорошо

Sourcery бесплатен для open source - если вам нравятся наши обзоры, пожалуйста, поделитесь ими ✨
Помогите мне быть полезнее! Пожалуйста, нажмите 👍 или 👎 на каждый комментарий, чтобы сообщить, был ли он полезен.
Original comment in English

Hey @TheHakerTech - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 9 issues found
  • 🟢 Security: all looks good
  • 🟡 Testing: 6 issues found
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

.github/workflows/test.yml Outdated Show resolved Hide resolved
ufpy/udict.py Outdated Show resolved Hide resolved
ufpy/udict.py Outdated Show resolved Hide resolved
ufpy/udict.py Outdated Show resolved Hide resolved
ufpy/udict.py Outdated Show resolved Hide resolved
ufpy/udict.py Outdated Show resolved Hide resolved
tests/test_udict.py Outdated Show resolved Hide resolved
ufpy/cmp.py Outdated Show resolved Hide resolved
ufpy/ustack.py Outdated Show resolved Hide resolved
ufpy/ustack.py Outdated Show resolved Hide resolved
@bleudev bleudev self-assigned this Jun 4, 2024
@bleudev bleudev added the new variable New variable label Jun 7, 2024
@bleudev bleudev marked this pull request as ready for review June 7, 2024 20:19
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мы пропустили проверку этого pull request. Похоже, что мы уже проверили этот pull request.

Original comment in English

We have skipped reviewing this pull request. It looks like we've already reviewed this pull request.

@bleudev bleudev self-requested a review June 7, 2024 20:19
@bleudev bleudev mentioned this pull request Jun 7, 2024
@bleudev bleudev merged commit 5405fcd into main Jun 7, 2024
2 checks passed
@bleudev bleudev deleted the ustack branch June 7, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first pull Good for newcomers new class New class new feature New feature new variable New variable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UStack object
2 participants