-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UStack #11
Conversation
@bleudev, answer |
@TheHakerTech add please unittests. check #3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very much work is going)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good with UStack realisation!
Reviewer's Guide by SourceryThis pull request introduces a new UStack object and makes several other significant changes, including the addition of the UDict class, examples, and tests. The changes are implemented by adding new files and modifying existing ones to support the new functionality. File-Level Changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Привет @TheHakerTech - я просмотрел ваши изменения, и они выглядят отлично!
Вот что я рассмотрел во время проверки
- 🟡 Общие проблемы: найдено 9 проблем
- 🟢 Безопасность: все выглядит хорошо
- 🟡 Тестирование: найдено 6 проблем
- 🟢 Сложность: все выглядит хорошо
Sourcery бесплатен для open source - если вам нравятся наши обзоры, пожалуйста, поделитесь ими ✨
Original comment in English
Hey @TheHakerTech - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 9 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 6 issues found
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
…etter; rename `list` to `elements`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Мы пропустили проверку этого pull request. Похоже, что мы уже проверили этот pull request.
Original comment in English
We have skipped reviewing this pull request. It looks like we've already reviewed this pull request.
New UStack object
Checklist:
closes #9