Fix context menu handling to prioritize link URLs and include anchor text as bookmark titles #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify to prioritize when saving bookmarks - Include selected anchor text as the bookmark title when saving links
| url: info.linkUrl, | ||
| title: info.selectionText ?? undefined, | ||
| }; | ||
| } else if (info.selectionText) { |
There was a problem hiding this comment.
hmmm, the ordering of the ifs makes me think that having text selection taking higher priority was some intentional decision. I'll need to remember why it was done that way :)
There was a problem hiding this comment.
Haha. Take your time. :)
There was a problem hiding this comment.
any update on this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When users select anchor text and click "Add to Hoarder," the extension was capturing the selected text instead of the link URL. As a result, only the selected text was saved in Hoarder.
Solution: Modified
handleContextMenuClickinbackground.ts:info.linkUrloverinfo.selectionTextwhen determining what to hoard.titlewhen saving a link bookmark.